Skip to content

[dotnet][rb][java][js][py] Automated Browser Version Update #16493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2025
Merged

[dotnet][rb][java][js][py] Automated Browser Version Update #16493

merged 1 commit into from
Oct 24, 2025
+17 −17

Conversation

@selenium-ci
Copy link
Member

@selenium-ci selenium-ci commented Oct 23, 2025 •
edited
Loading

This is an automated pull request to update pinned browsers and drivers

Merge after verify the new browser versions properly passing the tests and no bugs need to be filed

@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Oct 23, 2025 •
edited
Loading

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪
🎫 No ticket provided 
- [ ] Create ticket/issue <!-- /create_ticket --create_ticket=true -->

</details></td></tr>
Codebase Duplication Compliance
⚪
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
⚪
No custom compliance provided

Follow the guide to enable custom compliance check.

  • Update
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@selenium-ci selenium-ci added the B-build Includes scripting, bazel and CI integrations label Oct 23, 2025
@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Oct 23, 2025 •
edited
Loading

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Use a variable for version string

To improve maintainability, extract the hardcoded Chrome beta version string
into a variable and use it to construct the download URLs for the http_archive
definitions.

common/repositories.bzl [278-342]

+CHROME_BETA_VERSION = "142.0.7444.52"
 http_archive(
     name = "linux_beta_chrome",
-    url = "https://storage.googleapis.com/chrome-for-testing-public/142.0.7444.52/linux64/chrome-linux64.zip",
-    sha256 = "7660a9b9a3324c6e187d83add20ab6a6005d5ab3e2bd782ec4f7ca4510c4e0bcb",
+    url = "https://storage.googleapis.com/chrome-for-testing-public/{}/linux64/chrome-linux64.zip".format(CHROME_BETA_VERSION),
+    sha256 = "7660a9b9a3324c6e187d83add20ab6a6005d5ab3e2bd78ec4f7ca4510c4e0bcb",
     build_file_content = """
 ...
 )
 http_archive(
     name = "mac_beta_chrome",
-    url = "https://storage.googleapis.com/chrome-for-testing-public/142.0.7444.52/mac-x64/chrome-mac-x64.zip",
+    url = "https://storage.googleapis.com/chrome-for-testing-public/{}/mac-x64/chrome-mac-x64.zip".format(CHROME_BETA_VERSION),
     sha256 = "4e39fa17871951bd2c9120a78d38aae3b5552918724a84f485bc726d3ac6d259",
     strip_prefix = "chrome-mac-x64",
 ...
 )
 http_archive(
     name = "linux_beta_chromedriver",
-    url = "https://storage.googleapis.com/chrome-for-testing-public/142.0.7444.52/linux64/chromedriver-linux64.zip",
+    url = "https://storage.googleapis.com/chrome-for-testing-public/{}/linux64/chromedriver-linux64.zip".format(CHROME_BETA_VERSION),
     sha256 = "535eeb9797bdc9e46658d5d7454153ffd9c667a135d4a5b5e740465d449e4385",
     strip_prefix = "chromedriver-linux64",
 ...
 )
 
 http_archive(
     name = "mac_beta_chromedriver",
-    url = "https://storage.googleapis.com/chrome-for-testing-public/142.0.7444.52/mac-x64/chromedriver-mac-x64.zip",
+    url = "https://storage.googleapis.com/chrome-for-testing-public/{}/mac-x64/chromedriver-mac-x64.zip".format(CHROME_BETA_VERSION),
     sha256 = "b0dd906eb112de7611d2d791d92e3b1389dbba70e6118adc085beb736e2ea2c8",
     strip_prefix = "chromedriver-mac-x64",
 ...
 )

[To ensure code accuracy, apply this suggestion manually]

Suggestion importance[1-10]: 6

__

Why: The suggestion correctly identifies repeated version strings and proposes using a variable to improve maintainability, which is a valid and good practice directly related to the PR's changes.

Low
  • Update

@titusfortner
Copy link
Member

titusfortner commented Oct 23, 2025

Rerun tests after #16497 is merged

@selenium-ci selenium-ci force-pushed the pinned-browser-updates branch from 6480729 to 1c1d651 Compare October 24, 2025 00:42
@titusfortner titusfortner merged commit 72a925a into trunk Oct 24, 2025
47 checks passed
@titusfortner titusfortner deleted the pinned-browser-updates branch October 24, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

B-build Includes scripting, bazel and CI integrations Review effort 2/5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@selenium-ci @titusfortner